[H1] Igpack load errors written to the wrong map (copy-paste bug) #19

New issue

Closed

opened 2026-06-27 03:54:47 +00:00 by sessamekesh · 0 comments

sessamekesh commented

2026-06-27 03:54:47 +00:00

Owner

File: wasm/src/observable_filestore.cc:129

Inside load_igpack, a decode failure writes to the igasset error map instead of the igpack one:

auto decoder = igasset::IgpackDecoder::Create(std::move(data));
if (!decoder.has_value()) {
  igasset_load_errors_[path] = "Could not parse file as igpack";  // WRONG MAP
  return;
}

Impact:

A failed igpack surfaces under evt.igassets[path] instead of evt.igpacks[path] in the serialized event.
unload_igpack only erases igpack_load_errors_, so this error can never be cleared â€” it becomes sticky.

Fix: write to igpack_load_errors_[path].

Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the various-cleanup branch.

**File:** `wasm/src/observable_filestore.cc:129` Inside `load_igpack`, a decode failure writes to the **igasset** error map instead of the **igpack** one: ```cpp auto decoder = igasset::IgpackDecoder::Create(std::move(data)); if (!decoder.has_value()) { igasset_load_errors_[path] = "Could not parse file as igpack"; // WRONG MAP return; } ``` **Impact:** - A failed igpack surfaces under `evt.igassets[path]` instead of `evt.igpacks[path]` in the serialized event. - `unload_igpack` only erases `igpack_load_errors_`, so this error can never be cleared â€” it becomes sticky. **Fix:** write to `igpack_load_errors_[path]`. --- _Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the `various-cleanup` branch._

sessamekesh added the

bug:critical

filed-by-ai

needs-review

labels

2026-06-27 03:54:47 +00:00