[M3] GPUDevice leak on the cancelled-before-init path #24

New issue

Closed

opened 2026-06-27 03:54:47 +00:00 by sessamekesh · 0 comments

sessamekesh commented

2026-06-27 03:54:47 +00:00

Owner

File: packages/viewer-react/src/IgviewerContext.tsx (IgviewerSession)

If the effect is torn down before acquireIgviewerModule resolves:

The cleanup function (line 276) captures the (still empty) extraCleanup array and reassigns extraCleanup = [].
The async IIFE later resolves, sees cancelled, pushes the device-destroying cleanup onto the new array, and returns early (line 209).
Nothing ever runs that new array.

Impact: an internally-created GPUDevice (when no device prop was supplied) is never .destroy()-ed on a fast mount/unmount â€” a GPU resource leak.

Fix: run the captured cleanup callbacks in the cancelled branch too (destroy the device before the early return).

Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the various-cleanup branch.

**File:** `packages/viewer-react/src/IgviewerContext.tsx` (`IgviewerSession`) If the effect is torn down before `acquireIgviewerModule` resolves: 1. The cleanup function (line 276) captures the (still empty) `extraCleanup` array and reassigns `extraCleanup = []`. 2. The async IIFE later resolves, sees `cancelled`, pushes the device-destroying `cleanup` onto the **new** array, and returns early (line 209). 3. Nothing ever runs that new array. **Impact:** an internally-created `GPUDevice` (when no `device` prop was supplied) is never `.destroy()`-ed on a fast mount/unmount â€” a GPU resource leak. **Fix:** run the captured cleanup callbacks in the cancelled branch too (destroy the device before the early return). --- _Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the `various-cleanup` branch._

sessamekesh added the

bug

filed-by-ai

ai-eligible

labels

2026-06-27 03:54:47 +00:00