[M4] Demo: uploading state is never set to true #25

New issue

Closed

opened 2026-06-27 03:54:47 +00:00 by sessamekesh · 0 comments

sessamekesh commented 2026-06-27 03:54:47 +00:00

Owner

Copy link

File: demo/src/FilestoreOpsPanel.tsx:17-44

handleFileChange calls setUploading(false) in its finally block but never calls setUploading(true) at the start.

Impact: the "Uploading…" indicator (line 210-212) and the disabled state on the file input (line 197) are dead code — they never show.

Fix: setUploading(true) at the top of the handler (before the await file.arrayBuffer()).

---

Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the various-cleanup branch.

**File:** `demo/src/FilestoreOpsPanel.tsx:17-44` `handleFileChange` calls `setUploading(false)` in its `finally` block but never calls `setUploading(true)` at the start. **Impact:** the "Uploading…" indicator (line 210-212) and the `disabled` state on the file input (line 197) are dead code — they never show. **Fix:** `setUploading(true)` at the top of the handler (before the `await file.arrayBuffer()`). --- _Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the `various-cleanup` branch._

sessamekesh added the

bug

filed-by-ai

ai-eligible

labels 2026-06-27 03:54:47 +00:00

Ghost added the

ai-wip

label 2026-07-01 09:04:09 +00:00

Ghost referenced this issue from a commit 2026-07-01 09:14:15 +00:00

Fix: In `demo/src/FilestoreOpsPanel.tsx`, the `handleFileChange` async handler resets `uploading` to `false` in its `finally` block but never sets it to `true` at the start. As a result the "Uploading…" indicator and the `disabled={uploading}` guard on the file input are dead code — the input never disables and the indicator never renders during an upload.

sessamekesh closed this issue 2026-07-05 06:33:42 +00:00

sessamekesh referenced this issue from a commit 2026-07-05 06:33:44 +00:00

Fix: In `demo/src/FilestoreOpsPanel.tsx`, the `handleFileChange` async handler resets `uploading` to `false` in its `finally` block but never sets it to `true` at the start. As a result the "Uploading…" indicator and the `disabled={uploading}` guard … (#37)

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

various-cleanup

init-and-tests

No results found.

Labels

Clear labels   

ai-eligible

Issue identified as one that is a good candidate for AI bugfixes

  

ai-failed

Label for bugs that automated AI review systems attempted and failed.

  

ai-wip

Label for bugs that are currently being examined by an AI agent.

  

bug

Medium-severity bug

  

bug:cleanup

Low-severity cleanup / code smell

  

bug:critical

High-severity bug / likely incorrect behavior

  

filed-by-ai

Issue filed by an automated AI code review

  

needs-review

Needs review to decide if it's worth doing or not.

No labels

ai-eligible

ai-failed

ai-wip

bug

bug:cleanup

bug:critical

filed-by-ai

needs-review

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

indigocode/igasset-viewer-react#25

No description provided.