indigocode/igasset-viewer-react
2
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

[M5] Demo: upload-failure message renders as success (green) #26

New issue
Open
opened 2026-06-27 03:54:47 +00:00 by sessamekesh · 0 comments
sessamekesh commented 2026-06-27 03:54:47 +00:00
Owner
Copy link

File: demo/src/FilestoreOpsPanel.tsx:218

The result text is colored green when uploadResult.startsWith("Upload"):

color: uploadResult.startsWith("Upload") ? "#8f8" : "#f88",

Both the success string Uploaded "..." and the failure string Upload failed: ... start with "Upload", so failures render in the success color.

Fix: track success with an explicit boolean flag instead of string-prefix matching.

Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the various-cleanup branch.

**File:** `demo/src/FilestoreOpsPanel.tsx:218` The result text is colored green when `uploadResult.startsWith("Upload")`: ```tsx color: uploadResult.startsWith("Upload") ? "#8f8" : "#f88", ``` Both the success string `Uploaded "..."` **and** the failure string `Upload failed: ...` start with `"Upload"`, so **failures render in the success color**. **Fix:** track success with an explicit boolean flag instead of string-prefix matching. --- _Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the `various-cleanup` branch._
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
various-cleanup
init-and-tests
No results found.
Labels
Clear labels   
ai-eligible
Issue identified as one that is a good candidate for AI bugfixes

  
ai-failed
Label for bugs that automated AI review systems attempted and failed.

  
ai-wip
Label for bugs that are currently being examined by an AI agent.

  
bug
Medium-severity bug

  
bug:cleanup
Low-severity cleanup / code smell

  
bug:critical
High-severity bug / likely incorrect behavior

  
filed-by-ai
Issue filed by an automated AI code review

  
needs-review
Needs review to decide if it's worth doing or not.

No labels
ai-eligible
ai-failed
ai-wip
bug
bug:cleanup
bug:critical
filed-by-ai
needs-review
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
indigocode/igasset-viewer-react#26
No description provided.