indigocode/igasset-viewer-react
2
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

[M6] --sMAXIMUM_MEMORY has a double-dash typo (and no memory growth) #27

New issue
Open
opened 2026-06-27 03:54:47 +00:00 by sessamekesh · 1 comment
sessamekesh commented 2026-06-27 03:54:47 +00:00
Owner
Copy link

File: wasm/CMakeLists.txt:78

"--sMAXIMUM_MEMORY=1073741824"

should be -sMAXIMUM_MEMORY=... (compare the correct -sINITIAL_MEMORY on line 77). As written, emcc treats --sMAXIMUM_MEMORY as an unknown --s… driver flag.

Separately, MAXIMUM_MEMORY is only meaningful alongside -sALLOW_MEMORY_GROWTH, which is not set — so the heap is fixed at INITIAL_MEMORY (16 MiB) and the cap is inert regardless.

Fix: decide intent — either drop the line, or fix the flag and add -sALLOW_MEMORY_GROWTH.

Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the various-cleanup branch.

**File:** `wasm/CMakeLists.txt:78` ```cmake "--sMAXIMUM_MEMORY=1073741824" ``` should be `-sMAXIMUM_MEMORY=...` (compare the correct `-sINITIAL_MEMORY` on line 77). As written, emcc treats `--sMAXIMUM_MEMORY` as an unknown `--s…` driver flag. Separately, `MAXIMUM_MEMORY` is only meaningful alongside `-sALLOW_MEMORY_GROWTH`, which is not set — so the heap is fixed at `INITIAL_MEMORY` (16 MiB) and the cap is inert regardless. **Fix:** decide intent — either drop the line, or fix the flag *and* add `-sALLOW_MEMORY_GROWTH`. --- _Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the `various-cleanup` branch._
sessamekesh commented 2026-06-27 18:59:32 +00:00
Author
Owner
Copy link

This one requires some thought, removing ALLOW_MEMORY_GROWTH was part of a perf improvement story. It can be added back and be correct, but the "correct" decision here takes thought.

This one requires some thought, removing `ALLOW_MEMORY_GROWTH` was part of a perf improvement story. It can be added back and be correct, but the "correct" decision here takes thought.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
various-cleanup
init-and-tests
No results found.
Labels
Clear labels   
ai-eligible
Issue identified as one that is a good candidate for AI bugfixes

  
ai-failed
Label for bugs that automated AI review systems attempted and failed.

  
ai-wip
Label for bugs that are currently being examined by an AI agent.

  
bug
Medium-severity bug

  
bug:cleanup
Low-severity cleanup / code smell

  
bug:critical
High-severity bug / likely incorrect behavior

  
filed-by-ai
Issue filed by an automated AI code review

  
needs-review
Needs review to decide if it's worth doing or not.

No labels
ai-eligible
ai-failed
ai-wip
bug
bug:cleanup
bug:critical
filed-by-ai
needs-review
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
indigocode/igasset-viewer-react#27
No description provided.