indigocode/igasset-viewer-react
2
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

[L6] @types/react pinned to v18 while peerDeps allow v19 #32

New issue
Closed
opened 2026-06-27 03:54:48 +00:00 by sessamekesh · 0 comments
sessamekesh commented 2026-06-27 03:54:48 +00:00
Owner
Copy link

File: packages/viewer-react/package.json

peerDependencies allow react/react-dom ^18.2.0 || ^19.0.0, but the dev @types/react / @types/react-dom are pinned to ^18.2.0. Type-checking therefore validates against v18 types only, so v19-only type changes wouldn't be caught.

Fix: widen the dev types or add a v19 type-check matrix entry. Minor.

Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the various-cleanup branch.

**File:** `packages/viewer-react/package.json` `peerDependencies` allow `react`/`react-dom` `^18.2.0 || ^19.0.0`, but the dev `@types/react` / `@types/react-dom` are pinned to `^18.2.0`. Type-checking therefore validates against v18 types only, so v19-only type changes wouldn't be caught. **Fix:** widen the dev types or add a v19 type-check matrix entry. Minor. --- _Filed by an automated AI code review (manual proof-of-concept run). Code locations reference the `various-cleanup` branch._
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
various-cleanup
init-and-tests
No results found.
Labels
Clear labels   
ai-eligible
Issue identified as one that is a good candidate for AI bugfixes

  
ai-failed
Label for bugs that automated AI review systems attempted and failed.

  
ai-wip
Label for bugs that are currently being examined by an AI agent.

  
bug
Medium-severity bug

  
bug:cleanup
Low-severity cleanup / code smell

  
bug:critical
High-severity bug / likely incorrect behavior

  
filed-by-ai
Issue filed by an automated AI code review

  
needs-review
Needs review to decide if it's worth doing or not.

No labels
ai-eligible
ai-failed
ai-wip
bug
bug:cleanup
bug:critical
filed-by-ai
needs-review
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
indigocode/igasset-viewer-react#32
No description provided.