Observable filestore concurrency hardening #40

Merged

sessamekesh merged 6 commits from kamaron/observable-fs-thread-hardening into main 2026-07-07 02:12:51 +00:00

Conversation 0 Commits 6 Files changed 9 +217 -242

sessamekesh commented 2026-07-06 11:11:57 +00:00

Owner

Copy link

Main fix: All ObservableFilestore state mutations happen on the main thread, processing on exec threads.

Incidental / related: Thread pool now actually runs the exec_task_list, igasync version updated (via igasset update) to be resilient to a couple race conditions (whoops!), no longer spawn threads pessimistic on startup (do it only at runtime!), lifetime fixes on ObservableFilestore.

Incidental / related: Updated bindings.cc to not use emscripten::val directly (translates to any in TS - bad!) and to consume a TS function directly in the ObservableFilestore::subscribe method.

Main fix: All `ObservableFilestore` state mutations happen on the main thread, processing on exec threads. Incidental / related: Thread pool now actually runs the exec_task_list, igasync version updated (via igasset update) to be resilient to a couple race conditions (whoops!), no longer spawn threads pessimistic on startup (do it only at runtime!), lifetime fixes on `ObservableFilestore`. Incidental / related: Updated `bindings.cc` to not use `emscripten::val` directly (translates to `any` in TS - bad!) and to consume a TS function directly in the `ObservableFilestore::subscribe` method.

sessamekesh added 2 commits 2026-07-06 11:11:57 +00:00

[Pt1] ObservableFilestore - move all updates to main thread 0246c80ccf

Bugfixes... 0605e0e228

sessamekesh added 1 commit 2026-07-06 23:24:27 +00:00

Whoops, write to the right variable 4e1f427aeb

sessamekesh added 2 commits 2026-07-07 00:10:52 +00:00

Simplify ObservableFilestore.observe flow a1090c5282

Clean up more of the bindings 437e2dae97

sessamekesh added 1 commit 2026-07-07 02:06:34 +00:00

Final tweaks before PR review 7573124e75

sessamekesh merged commit 88a2fadbc0 into main 2026-07-07 02:12:51 +00:00

sessamekesh deleted branch kamaron/observable-fs-thread-hardening 2026-07-07 02:12:51 +00:00

sessamekesh referenced this pull request from a commit 2026-07-07 02:12:53 +00:00

Observable filestore concurrency hardening (#40)

sessamekesh referenced this pull request 2026-07-07 02:13:29 +00:00

[H2] Data race on the loaded/error maps once exec runs off-thread #20

sessamekesh referenced this pull request 2026-07-07 02:13:45 +00:00

[H3] Thread pool never receives its task list - multithreading is a no-op #21

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

ai-eligible

Issue identified as one that is a good candidate for AI bugfixes

  

ai-failed

Label for bugs that automated AI review systems attempted and failed.

  

ai-wip

Label for bugs that are currently being examined by an AI agent.

  

bug

Medium-severity bug

  

bug:cleanup

Low-severity cleanup / code smell

  

bug:critical

High-severity bug / likely incorrect behavior

  

filed-by-ai

Issue filed by an automated AI code review

  

needs-review

Needs review to decide if it's worth doing or not.

No labels

ai-eligible

ai-failed

ai-wip

bug

bug:cleanup

bug:critical

filed-by-ai

needs-review

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

indigocode/igasset-viewer-react!40

No description provided.